Commit graph

30 commits

Author SHA1 Message Date
Zen
ba3295885c removed --webm flag 2021-08-16 20:17:33 +03:00
Zen
c47e19bead Check validity of output file path 2021-08-06 19:06:39 +03:00
redzic
bf1b6e98b8
Better logging, integrate av1an-pyo3 into av1an-core (#314)
Implements more robust logging via flexi_logger. This replaces the old
logging implementation, and is also more ergonomic, since macros from the
`log` crate are now used instead of `format!` directly. Now, warnings
and errors are also logged to stderr, in addition to the log file.

This also removes av1an-pyo3, and integrates the code into av1an-core.

Concatenation with FFmpeg is now handled on Windows differently than
other platforms through conditional compilation. FFmpeg seems to need
double backslashes in the concat file, so this is explicitly handled
in the Windows build now. Also, the spinner is now disabled on Windows
builds since the default command prompt cannot display the characters
correctly.
2021-07-25 10:31:54 +03:00
redzic
4ef9bdaa8a
More idiomatic Rust, add Cargo.lock to the repo (#313)
Previously, we represented quantizer values as an owned `String` for
constructing various encoder commands, which is much slower and less
robust than representing the quantizer as an integral value. This has
been updated to represent the `q` and `n_threads` both as a `usize`, and
only convert to a `String` for formatting as needed.

Furthermore, several struct fields containing paths have been updated to
use a `PathBuf` or `&Path` instead of a `String`. These are the first
steps required to supporting non-UTF8 filenames on Windows and
Unix-based operating systems.

`run_vmaf_on_chunk`'s function signature has been update to take generic
arguments that satisfy `AsRef<Path>`, which allows the caller to save
themselves from creating a new `Path` if the original argument was a
`String`, for example.

* Do not represent the concatenation method as a string
* Fix pedantic clippy warnings
* Remove Cargo.lock from .gitignore
* Fix startup_check for ivf concatenation
* Add doc comment to `Args` for better help generation in Clap
* Use Display impl instead of directly using str::From for `Encoder` and `ConcatMethod`
* Do not unwrap the result of killing child processes
* Assert that VMAF calculation was successful
* Use more idiomatic Rust
2021-07-24 20:09:21 +03:00
Josh Holmer
772eddd103
Add --verbose flag to show worker progress bars (#311) 2021-07-20 05:05:18 +03:00
redzic
0b7391c434
Fix some clippy warnings, use enums instead of strings (#309) 2021-07-19 05:04:08 +03:00
redzic
25f2eba75e
Fix default audio parameters (#306) 2021-07-19 03:49:01 +03:00
redzic
2b2138da5f
Remove all remaining Python code (#302) 2021-07-19 01:52:05 +03:00
Zen
a53ca400b7 Remove pyscene detectect 2021-07-12 23:14:42 +03:00
Zen
5b07da10cb Remove ffmpeg scenedetection 2021-07-12 07:05:43 +03:00
redzic
3e30b31499
Add av-scenechange as the new and default scene detector (#292)
* Fix clippy warnings, run `cargo fmt`
* Add clippy::needless_pass_by_value lint to av1an-core
* Add av-scenechange as the new and default scene detector
2021-07-12 06:08:37 +03:00
Luigi311
308e97047e
Add probe slow, add devcontainer, update readme (#289)
* Dockerfile: Update copy with chown, seperate copy requirements from all
* Add probe-slow support
* README: Update readme with new rust cli options
* Dockerfile: Hide av1an venv
* Add devcontainer
* Action: Add baseline-select
2021-07-09 19:32:47 +03:00
Zen
928562b401 removed no check 2021-07-01 10:38:00 +03:00
Zen
0794a5bd59 remove aomenc keyframes 2021-06-28 06:11:17 +03:00
Zen
0320ce6773 removed plot probes and dead code 2021-06-28 02:47:05 +03:00
Zen
827c6993b1 remove target quality slow probe 2021-06-27 23:12:27 +03:00
Zen
b7afc0ce96 fix cli 2021-06-16 17:46:33 +03:00
redzic
018999a5fb
Port logging to Rust, fix clippy warnings and remove dead code (#280)
Port logging to Rust
2021-06-14 23:20:47 +03:00
Zen
e33f5b8831 removed reusing of first pass aom 2021-06-11 02:08:40 +03:00
Luis Garcia
da32f15ffe
Probe slow (#277)
Add probe-slow
2021-06-09 00:39:14 +03:00
Zen
2d4366aafa fix tests 2021-06-05 10:38:22 +03:00
Zen
755223e1fc fix logging 2021-06-05 03:40:28 +03:00
Zen
a94852e4ed fix output file 2021-06-05 03:29:53 +03:00
Zen
9affd557ee removed config code 2021-05-31 02:41:12 +03:00
Zen
4c314b96de fix tests 2021-06-04 22:45:11 +03:00
Zen
b4351e7e23 improved chunk_method args 2021-06-04 22:19:40 +03:00
Zen
1ec33cc065 fixes 2021-06-04 22:12:44 +03:00
Zen
a488e98c04 Fix args 2021-06-04 05:05:15 +03:00
Zen
7740da8f0d move arg parsing to rust 2021-06-04 04:27:14 +03:00
Zen
060d057c63 Wip rust arg parsing 2021-06-03 11:43:50 +03:00